-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*_member_create don't raise validation errors #3108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add not_missing to the schema and raise the errors on the action. Adds some tests as well
@@ -151,7 +151,6 @@ def setup_class(cls): | |||
|
|||
@classmethod | |||
def teardown_class(cls): | |||
p.unload('image_view') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this related?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what happened here, I pushed a commit fixing it
amercader
added a commit
that referenced
this pull request
Jun 15, 2016
k-nut
pushed a commit
to k-nut/ckan
that referenced
this pull request
Jul 4, 2016
Add not_missing to the schema and raise the errors on the action. Adds some tests as well
k-nut
pushed a commit
to k-nut/ckan
that referenced
this pull request
Jul 4, 2016
k-nut
pushed a commit
to k-nut/ckan
that referenced
this pull request
Jul 4, 2016
k-nut
pushed a commit
to k-nut/ckan
that referenced
this pull request
Jul 4, 2016
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
Add not_missing to the schema and raise the errors on the action. Adds some tests as well
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
Conflicts: ckan/logic/schema.py
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
Add not_missing to the schema and raise the errors on the action. Adds some tests as well
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
Conflicts: ckan/logic/schema.py
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
Add not_missing to the schema and raise the errors on the action. Adds some tests as well
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
Conflicts: ckan/logic/schema.py
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
organization_member_create
andgroup_member_create
don't raise validation errors if one of the parameters is missing (id
,username
orrole
, all mandatory).This leads to confusing failures when submitting eg a key with an extra space (
"username "
):